Conversation
A rule kept in a side document is a rule nobody reads, which is how the architecture tree in this file drifted out of date. Reference material that is not a rule keeps its own file and is linked from here.
Two things the migration to CI-based analysis surfaced. The quality gate on main fails on one condition: new code is scored at 0% coverage against a threshold of 80, because no coverage report has ever been uploaded. The 3.12 matrix leg now runs pytest under coverage and hands the report to the scanner as an artifact. .coveragerc sets relative_files because the report is produced on Windows and read by a Linux scanner, so it must not carry an absolute source root. Real coverage is 57% overall -- utils and tools_gui sit at 95-100%, the UI layer between 20% and 45% -- so this reports an honest number rather than necessarily clearing the gate. SonarCloud's plan for this organization exposes results for main and for pull requests only. An analysis pushed for dev is accepted and its compute-engine task succeeds, but every read of it returns 403, and no project in the organization has a branch other than main. Scanning each push to dev therefore spent CI time producing numbers nobody can see, so dev.yml now scans pull requests only; stable.yml still scans pushes to main.
Up to standards ✅🟢 Issues
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #132, which moved SonarCloud to CI-based analysis. Two things that
migration surfaced.
Coverage
The quality gate on
mainfails on exactly one condition — new code scored at0% coverage against a threshold of 80 — because no coverage report has ever been
uploaded. The 3.12 matrix leg now runs pytest under coverage and hands the report
to the scanner as an artifact.
.coveragercsetsrelative_files = True: the report is produced on Windows andread by a Linux scanner, so it must not carry an absolute
<source>root.Real coverage is 57% overall —
utils/andtools_guisit at 95–100%, theUI layer between 20% and 45%. This reports an honest number; it does not
necessarily clear the 80 threshold.
Scan scope
SonarCloud's plan for this organization exposes results for
mainand for pullrequests only. An analysis pushed for
devis accepted and its compute-enginetask succeeds, but every read of it returns 403, and no project in the
organization has a branch other than
main. Scanning each push todevwasspending CI time on numbers nobody can see, so
dev.ymlnow scans pull requestsonly.
stable.ymlstill scans pushes tomain.Both
sonarcloudjobs gainneeds: unit-testsso they can consume the artifact.Merging this publishes 1.0.29 to PyPI, as every merge to
maindoes.